lcspinter commented on a change in pull request #2382:
URL: https://github.com/apache/hive/pull/2382#discussion_r650885975
##########
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
##########
@@ -311,6 +312,38 @@ public void
rollbackAlterTable(org.apache.hadoop.hive.metastore.api.Table hmsTab
}
}
+ private void alterTableProperties(org.apache.hadoop.hive.metastore.api.Table
hmsTable,
+ Map<String, String> contextProperties) {
+ Map<String, String> hmsTableParameters = hmsTable.getParameters();
+ Splitter splitter = Splitter.on(PROPERTIES_SEPARATOR);
+ UpdateProperties icebergUpdateProperties = icebergTable.updateProperties();
+ if (contextProperties.containsKey(SET_PROPERTIES)) {
+ splitter.splitToList(contextProperties.get(SET_PROPERTIES))
+ .forEach(k -> icebergUpdateProperties.set(k,
hmsTableParameters.get(k)));
Review comment:
You are right, we should do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
