aasha commented on a change in pull request #2240:
URL: https://github.com/apache/hive/pull/2240#discussion_r652410662



##########
File path: 
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ranger/RangerRestClientImpl.java
##########
@@ -79,32 +79,29 @@
   public RangerExportPolicyList exportRangerPolicies(String 
sourceRangerEndpoint,
                                                      String dbName,
                                                      String 
rangerHiveServiceName,
-                                                     HiveConf hiveConf)throws 
SemanticException {
+                                                     HiveConf hiveConf)throws 
Exception {
     LOG.info("Ranger endpoint for cluster " + sourceRangerEndpoint);
     if (StringUtils.isEmpty(rangerHiveServiceName)) {
       throw new 
SemanticException(ErrorMsg.REPL_INVALID_CONFIG_FOR_SERVICE.format("Ranger 
Service Name " +
         "cannot be empty", ReplUtils.REPL_RANGER_SERVICE));
     }
+    String finalUrl = getRangerExportUrl(sourceRangerEndpoint, 
rangerHiveServiceName, dbName);
+    LOG.debug("Url to export policies from source Ranger: {}", finalUrl);
     Retryable retryable = Retryable.builder()
       .withHiveConf(hiveConf).withFailOnException(RuntimeException.class)
-      .withRetryOnException(URISyntaxException.class).build();
+      .withRetryOnException(Exception.class).build();

Review comment:
       RuntimeException is a subclass of Exception. If you retry on Exception, 
RuntimeException will also get retried




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to