kasakrisz commented on a change in pull request #2401:
URL: https://github.com/apache/hive/pull/2401#discussion_r657770038



##########
File path: 
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/alter/rebuild/AlterMaterializedViewRebuildAnalyzer.java
##########
@@ -353,6 +375,23 @@ private RelNode toJoinInsertIncremental(
               basePlan, mdProvider, executorProvider, 
HiveJoinInsertIncrementalRewritingRule.INSTANCE);
     }
 
+    private RelNode toPartitionInsertOverwrite(
+            RelNode basePlan, RelMetadataProvider mdProvider, RexExecutor 
executorProvider,
+            HiveRelOptMaterialization materialization, RelNode 
calcitePreMVRewritingPlan) {
+
+      if (materialization.isSourceTablesUpdateDeleteModified()) {
+        return calcitePreMVRewritingPlan;
+      }
+
+      RelOptHiveTable hiveTable = (RelOptHiveTable) 
materialization.tableRel.getTable();
+      if (!AcidUtils.isInsertOnlyTable(hiveTable.getHiveTableMD())) {
+        return applyPreJoinOrderingTransforms(basePlan, mdProvider, 
executorProvider);
+      }
+
+      return toIncrementalRebuild(
+              basePlan, mdProvider, executorProvider, 
HiveAggregatePartitionIncrementalRewritingRule.INSTANCE);
+    }
+
     private RelNode toIncrementalRebuild(

Review comment:
       renamed all to* methods to apply* in this class




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to