kishendas commented on a change in pull request #2425:
URL: https://github.com/apache/hive/pull/2425#discussion_r673413945
##########
File path:
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
##########
@@ -610,6 +637,8 @@ struct Partition {
10: optional i64 writeId=-1,
11: optional bool isStatsCompliant,
12: optional ColumnStatistics colStats // column statistics for partition
Review comment:
Comma is missing after colStats. Does this still work fine, when you
generate the code ?
##########
File path:
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
##########
@@ -610,6 +637,8 @@ struct Partition {
10: optional i64 writeId=-1,
11: optional bool isStatsCompliant,
12: optional ColumnStatistics colStats // column statistics for partition
+ 13: optional FileMetadata fileMetadata // optional serialized file-metadata
useful
+ // for certain execution engines
Review comment:
Please align the comment
##########
File path:
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
##########
@@ -595,6 +619,9 @@ struct Table {
24: optional list<string> requiredWriteCapabilities
25: optional i64 id, // id of the table. It will be ignored
if set. It's only for
// read purposed
+ 26: optional FileMetadata fileMetadata // optional serialized file-metadata
for this table
+ // for certain execution engines
Review comment:
You want to align this comment with previous line, so that its easy to
read ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
