ashish-kumar-sharma commented on a change in pull request #2445:
URL: https://github.com/apache/hive/pull/2445#discussion_r673814327
##########
File path:
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java
##########
@@ -1254,10 +1257,13 @@ public static Timestamp getTimestampFromString(String
s) {
s = s.trim();
s = trimNanoTimestamp(s);
+ if(StringUtils.isEmpty(s))
+ return null;
+
try {
return TimestampUtils.stringToTimestamp(s);
- } catch (IllegalArgumentException e) {
- return null;
+ } catch (IllegalArgumentException | DateTimeException e) {
+ throw new IllegalArgumentException("Cannot parse " + s);
Review comment:
reverted to null as discussed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
