zabetak commented on a change in pull request #2504:
URL: https://github.com/apache/hive/pull/2504#discussion_r681602712
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/jdbc/JDBCAbstractSplitFilterRule.java
##########
@@ -172,13 +172,14 @@ public boolean matches(RelOptRuleCall call) {
final HiveJdbcConverter conv = call.rel(2);
RexNode joinCond = join.getCondition();
+ SqlDialect dialect = conv.getJdbcDialect();
- return super.matches(call) &&
JDBCRexCallValidator.isValidJdbcOperation(joinCond, conv.getJdbcDialect());
+ return super.matches(call, dialect) &&
JDBCRexCallValidator.isValidJdbcOperation(joinCond, dialect);
Review comment:
I've seen the change
https://github.com/apache/hive/pull/2504/commits/058a0796e9ac0d0e664a8ede553d5bdb5be8ec0c.
Actually I would like the whole method to go away and not only the method
call. I will apply this minor change locally before merging this to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
