pvary commented on a change in pull request #2427:
URL: https://github.com/apache/hive/pull/2427#discussion_r684151918
##########
File path:
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerNoScan.java
##########
@@ -764,7 +764,7 @@ public void testIcebergAndHmsTableProperties() throws
Exception {
Assert.assertEquals(expectedIcebergProperties, icebergTable.properties());
if (Catalogs.hiveCatalog(shell.getHiveConf(), tableProperties)) {
- Assert.assertEquals(10, hmsParams.size());
+ Assert.assertEquals(11, hmsParams.size());
Review comment:
It was an empty stat. `{}`
This was not a big issue, but found a better way. Let's see if this breaks
anything :)
##########
File path:
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerWithEngine.java
##########
@@ -2235,12 +2245,13 @@ public void testStatWithPartitionedInsert() {
String insert =
testTables.getInsertQuery(HiveIcebergStorageHandlerTestUtils.CUSTOMER_RECORDS,
identifier, false);
shell.executeStatement(insert);
- checkColStat("customers", "customer_id");
- checkColStat("customers", "first_name");
+ checkColStat("customers", "customer_id", true);
+ checkColStat("customers", "first_name", true);
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
