deniskuzZ commented on pull request #2547: URL: https://github.com/apache/hive/pull/2547#issuecomment-896692730
> > > > Would be great if you could run the HMS benchmark and see if that has affected the commit step performance. See if the index on opType improves the situation. > > > > > > > > > There is no benchmark currently for the commitTxn() call. > > > > > > Could we create one or at least perform similar to https://issues.apache.org/jira/browse/HIVE-23104?focusedCommentId=17083005&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17083005 test? > > Based on the linked comment it is not clear to me what exactly was tested and how or what tools were used for it or what environment the tests were run in. I found no mention of the above details in the jira comments. You are not limited in a set of tools or approaches, free to choose any. This patch changes the way how INSERTs are handled at the commit step, so it would make sense to test the throughput of INSERT/UPDATE operations in multithreaded env. AFAIK in the above JIRA JMH tool was used and testing was done on a local env. We cannot merge this PR until we know the performance effect of the proposed change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
