abstractdog commented on a change in pull request #2664:
URL: https://github.com/apache/hive/pull/2664#discussion_r716686066
##########
File path: serde/src/test/org/apache/hadoop/hive/serde2/TestJsonSerDe.java
##########
@@ -74,6 +74,76 @@ public void testPrimativeDataTypes() throws Exception {
Assert.assertEquals(Timestamp.ofEpochMilli(1549751270013L),
results.get(4));
}
+ @Test
Review comment:
these unit tests are useful, thanks!
would you consider adding a qtest, which can describe the whole scenario
better (create table with property, load data, having json in string column)?
I saw you added the sample json files under data/files, so I guess you
wanted to add qtest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
