pkumarsinha commented on a change in pull request #2655:
URL: https://github.com/apache/hive/pull/2655#discussion_r716418809
##########
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosIncrementalLoadAcidTables.java
##########
@@ -243,6 +248,53 @@ public void testReplCM() throws Throwable {
Lists.newArrayList(result, result));
}
+ @Test
+ public void testReplCommitTransactionOnSourceDelete() throws Throwable {
+ String tableName = "testReplCommitTransactionOnSourceDelete";
+ String[] result = new String[] { "5" };
+
+ // Do a bootstrap dump.
+ WarehouseInstance.Tuple bootStrapDump = primary.dump(primaryDbName);
+ replica.load(replicatedDbName, primaryDbName).run("REPL STATUS " +
replicatedDbName)
+ .verifyResult(bootStrapDump.lastReplicationId);
+
+ // Add some data to the table & do a incremental dump.
+ ReplicationTestUtils.insertRecords(primary, primaryDbName,
primaryDbNameExtra, tableName, null, false,
+ ReplicationTestUtils.OperationType.REPL_TEST_ACID_INSERT);
+ WarehouseInstance.Tuple incrementalDump = primary.dump(primaryDbName);
Review comment:
Can you please add the tables with following property:
- ORC Format (I think covered)
- bucketed
- text input format
All these tables should have a drop table use case like you are targeting
now?
##########
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosIncrementalLoadAcidTables.java
##########
@@ -243,6 +248,64 @@ public void testReplCM() throws Throwable {
Lists.newArrayList(result, result));
}
+ @Test
+ public void testReplCommitTransactionOnSourceDeleteORC() throws Throwable {
+ // Run test with ORC format & with transactional true.
+ testReplCommitTransactionOnSourceDelete("STORED AS ORC",
"'transactional'='true'");
+ }
+
+ @Test
+ public void testReplCommitTransactionOnSourceDeleteText() throws Throwable {
+ // Run test with TEXT format & with transactional true.
Review comment:
false?
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/CopyUtils.java
##########
@@ -401,6 +404,18 @@ private boolean isSourceFileMismatch(FileSystem sourceFs,
ReplChangeManager.File
return false;
}
+ @VisibleForTesting
+ private void runTestOnlyExecutions() throws IOException {
Review comment:
Wondering if this logic can be. moved to test itself
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/CopyUtils.java
##########
@@ -65,6 +65,8 @@
private final String copyAsUser;
private FileSystem destinationFs;
private final int maxParallelCopyTask;
+ @VisibleForTesting
Review comment:
If the method is public does the annotation VisibleForTesting have any
impact?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
