kasakrisz commented on a change in pull request #2682:
URL: https://github.com/apache/hive/pull/2682#discussion_r718389730



##########
File path: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
##########
@@ -2554,10 +2554,10 @@ public Materialization 
getMaterializationInvalidationInfo(
       queryCompletedCompactions.append(" AND (\"CC_HIGHEST_WRITE_ID\" > " + 
tblValidWriteIdList.getHighWatermark());
       queryUpdateDelete.append(tblValidWriteIdList.getInvalidWriteIds().length 
== 0 ? ") " :
               " OR \"CTC_WRITEID\" IN(" + StringUtils.join(",",
-                      
Arrays.asList(ArrayUtils.toObject(tblValidWriteIdList.getInvalidWriteIds()))) + 
") ");
+                      
Arrays.asList(ArrayUtils.toObject(tblValidWriteIdList.getInvalidWriteIds()))) + 
") ) ");

Review comment:
       One more closing parenthese `)` was added:
   ```
   before: ") ");
   after: ") ) ");   
   ```
   
   

##########
File path: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
##########
@@ -2554,10 +2554,10 @@ public Materialization 
getMaterializationInvalidationInfo(
       queryCompletedCompactions.append(" AND (\"CC_HIGHEST_WRITE_ID\" > " + 
tblValidWriteIdList.getHighWatermark());
       queryUpdateDelete.append(tblValidWriteIdList.getInvalidWriteIds().length 
== 0 ? ") " :
               " OR \"CTC_WRITEID\" IN(" + StringUtils.join(",",
-                      
Arrays.asList(ArrayUtils.toObject(tblValidWriteIdList.getInvalidWriteIds()))) + 
") ");
+                      
Arrays.asList(ArrayUtils.toObject(tblValidWriteIdList.getInvalidWriteIds()))) + 
") ) ");

Review comment:
       One more closing parenthesis `)` was added:
   ```
   before: ") ");
   after: ") ) ");   
   ```
   
   

##########
File path: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
##########
@@ -2554,10 +2554,10 @@ public Materialization 
getMaterializationInvalidationInfo(
       queryCompletedCompactions.append(" AND (\"CC_HIGHEST_WRITE_ID\" > " + 
tblValidWriteIdList.getHighWatermark());
       queryUpdateDelete.append(tblValidWriteIdList.getInvalidWriteIds().length 
== 0 ? ") " :
               " OR \"CTC_WRITEID\" IN(" + StringUtils.join(",",
-                      
Arrays.asList(ArrayUtils.toObject(tblValidWriteIdList.getInvalidWriteIds()))) + 
") ");
+                      
Arrays.asList(ArrayUtils.toObject(tblValidWriteIdList.getInvalidWriteIds()))) + 
") ) ");

Review comment:
       One more closing parenthesis `)` was added:
   ```
   before: ") "
   after: ") ) "   
   ```
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to