nrg4878 commented on a change in pull request #2634:
URL: https://github.com/apache/hive/pull/2634#discussion_r719521711
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
##########
@@ -5461,6 +5462,37 @@ public GetPartitionResponse
get_partition_req(GetPartitionRequest req)
*/
private void fireReadTablePreEvent(String catName, String dbName, String
tblName)
throws MetaException, NoSuchObjectException {
+ if (catName == null) {
+ throw new NullPointerException("catName is null");
+ }
+
+ if (isBlank(catName)) {
+ throw new NoSuchObjectException("catName is not valid");
+ }
+
+ if (dbName == null) {
+ throw new NullPointerException("dbName is null");
+ }
+
+ if (isBlank(dbName)) {
Review comment:
Same here. Converge them into a single condition or even merge with the
catalog condition
if catName == null || isBlank(catName) || dbName == null || isBlank(dbName)
throw NoSuchObjectException
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
