pvary commented on a change in pull request #2701:
URL: https://github.com/apache/hive/pull/2701#discussion_r724382858
##########
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java
##########
@@ -120,16 +124,23 @@ public void commitTask(TaskAttemptContext
originalContext) throws IOException {
if (table != null) {
HiveIcebergRecordWriter writer = writers.get(output);
DataFile[] closedFiles;
+ List<DeleteFile> deleteFiles = Collections.emptyList();
if (writer != null) {
closedFiles = writer.dataFiles();
+ deleteFiles = writer.getDeleteFiles();
} else {
LOG.info("CommitTask found no writer for specific table: {},
attemptID: {}", output, attemptID);
closedFiles = new DataFile[0];
}
String fileForCommitLocation =
generateFileForCommitLocation(table.location(), jobConf,
attemptID.getJobID(), attemptID.getTaskID().getId());
// Creating the file containing the data files generated by this
task for this table
- createFileForCommit(closedFiles, fileForCommitLocation,
table.io());
+ if (!deleteFiles.isEmpty()) {
Review comment:
Are these mutually exclusive?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
