pkumarsinha commented on a change in pull request #2707:
URL: https://github.com/apache/hive/pull/2707#discussion_r726553964
##########
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestScheduledReplicationScenarios.java
##########
@@ -251,6 +253,97 @@ public void testExternalTablesReplLoadBootstrapIncr()
throws Throwable {
}
}
+ @Test
+ public void testCompleteFailoverWithReverseBootstrap() throws Throwable {
+ String withClause =
+ "'" + HiveConf.ConfVars.HIVE_IN_TEST + "' = 'true'" + ",'"
+ + HiveConf.ConfVars.REPL_SOURCE_CLUSTER_NAME + "' =
'cluster0'"
Review comment:
Why is cluster name required in with clause? Is it used during fail-over
process?
##########
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestScheduledReplicationScenarios.java
##########
@@ -251,6 +253,97 @@ public void testExternalTablesReplLoadBootstrapIncr()
throws Throwable {
}
}
+ @Test
+ public void testCompleteFailoverWithReverseBootstrap() throws Throwable {
+ String withClause =
+ "'" + HiveConf.ConfVars.HIVE_IN_TEST + "' = 'true'" + ",'"
+ + HiveConf.ConfVars.REPL_SOURCE_CLUSTER_NAME + "' =
'cluster0'"
+ + ",'" + HiveConf.ConfVars.REPL_TARGET_CLUSTER_NAME
+ + "' = 'cluster1'";
+
+ // Create a table with some data at source DB.
+ primary.run("use " + primaryDbName).run("create table t2 (id int)")
+ .run("insert into t2 values(1)").run("insert into t2 values(2)");
+
+ // Schedule Dump & Load and verify the data is replicated properly.
+ try (ScheduledQueryExecutionService schqS = ScheduledQueryExecutionService
+ .startScheduledQueryExecutorService(primary.hiveConf)) {
+ int next = -1;
+ ReplDumpWork.injectNextDumpDirForTest(String.valueOf(next), true);
+ primary.run("create scheduled query repl_dump_p1 every 5 seconds as repl
dump "
+ + primaryDbName + " WITH(" + withClause + ')');
Review comment:
What dump directory is used here for both set of policies, p1 & p2? We
should have tests for both these cases. Also, failback ideally should also be
covered as a part of these test as that would help ascertain the full
functioning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
