zabetak commented on pull request #2432: URL: https://github.com/apache/hive/pull/2432#issuecomment-958309007
> What is responsible for cleaning up these files? Could there be a case where the cleanup process happens and then the file is re-created and never scheduled for cleanup again? @belugabehr It's been a while since I have worked on this code but if I remember well the operation log file deletion is handled by `OperationLogCleaner`. When the query/operation ends it is registered for cleanup (see https://github.com/apache/hive/blob/6e152aa28bc5116bf9210f9deb0f95d2d73183f7/service/src/java/org/apache/hive/service/cli/operation/Operation.java#L323) . The deletion may happen immediately or with some delay as specified by the properties. If for some reason there is a log event for the **same** query after the cleanup then I assume the file will be recreated and it will never be removed from the file-system. This could happen even without the changes introduced in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
