marton-bod commented on a change in pull request #2750:
URL: https://github.com/apache/hive/pull/2750#discussion_r742985061



##########
File path: 
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergSplit.java
##########
@@ -68,6 +73,23 @@ public Path getPath() {
     return new Path(tableLocation);
   }
 
+  @Override
+  public byte[] getBytesForHash() {
+    Collection<FileScanTask> fileScanTasks = innerSplit.task().files();
+
+    try (ByteArrayOutputStream baos = new ByteArrayOutputStream()) {
+      for (FileScanTask task : fileScanTasks) {
+        baos.write(task.file().path().toString().getBytes());
+        byte[] startBytes = new byte[Long.BYTES];
+        SerDeUtils.writeLong(startBytes, 0, task.start());
+        baos.write(startBytes);
+      }
+      return baos.toByteArray();
+    } catch (IOException ioe) {
+      throw new RuntimeException("Couldn't produce hash input bytes for 
HiveIcebergSplit: " + this, ioe);

Review comment:
       Okay, makes sense




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to