zabetak opened a new pull request #2790: URL: https://github.com/apache/hive/pull/2790
### What changes were proposed in this pull request? 1. Use dependency management section for setting version, scope, and optionality of a JDBC driver. 2. Remove download-maven-plugin. 3. Add explicit dependencies to drivers when necessary. 4. Gather JDBC declarations together in dependency management. ### Why are the changes needed? 1. Eliminates the risk to write code which needs JDBC driver classes in order to compile and potentially violate AL2. 2. Unifies the declaration of JDBC drivers making easier to add/remove one if necessary. 3. Removes the need to use download-maven-plugin and other similar workarounds to avoid licensing problems. 4. Simplifies the execution of tests using these drivers since now they are added in the runtime classpath automatically by maven. 5. Projects with dependencies depending on Hive will not inherit any JDBC driver by default. ### Does this PR introduce _any_ user-facing change? Projects depending on Hive modules with derby must now declare the JDBC driver dependency explicitly. ### How was this patch tested? 1. Run various tests dependent on the presence of JDBC drivers ``` cd standalone-metastore/metastore-server mvn verify -DskipITests=false -Dtest=nosuch -Dit.test=ITestDerby mvn verify -DskipITests=false -Dtest=nosuch -Dit.test=ITestPostgres mvn verify -DskipITests=false -Dtest=nosuch -Dit.test=ITestOracle mvn verify -DskipITests=false -Dtest=nosuch -Dit.test=ITestMysql mvn verify -DskipITests=false -Dtest=nosuch -Dit.test=ITestMssql cd itests/qtest mvn test -Dtest=TestMiniLlapLocalCliDriver -Dqfile_regex=jdbc_table_with_schema.* ``` 2. Ensure JDBC drivers appear as runtime & optional via mvn dependency:tree -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
