dengzhhu653 edited a comment on pull request #2860: URL: https://github.com/apache/hive/pull/2860#issuecomment-992474538
> > I am not sure if it appropriate to introduce more metrics about the apis. > > I thought we may easily recognize retrying cases by comparing two api metrics, whether apis succeeds or not. This approach doesn't break anything. It gives us more accurate metrics, and users can pick metrics which they want to collect, if they don't want both. On a long running metastore instance, the two different metrics may be almost the same, and some HMSHandler methods do not have `startFunction` and `endFunction` to measure the time spent, it may bring some ambiguities and memory pressure. Just my thought, Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
