sourabh912 commented on a change in pull request #2864:
URL: https://github.com/apache/hive/pull/2864#discussion_r769474574
##########
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
##########
@@ -4201,6 +4202,20 @@ public NotificationEventResponse
getNextNotification(long lastEventId, int maxEv
NotificationFilter
filter) throws TException {
NotificationEventRequest rqst = new NotificationEventRequest(lastEventId);
rqst.setMaxEvents(maxEvents);
+ return getNextNotificationsInternal(rqst, false, filter);
+ }
+
+ @Override
+ public NotificationEventResponse
getNextNotification(NotificationEventRequest request,
Review comment:
Instead of defining a new getNextNotification api, would it be cleaner
if we add `allowGapsInEventIds` as an option in NotificationEventRequest?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
