pvary commented on a change in pull request #2865:
URL: https://github.com/apache/hive/pull/2865#discussion_r769598125
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
##########
@@ -673,8 +672,7 @@ Operator genOPTree(ASTNode ast, PlannerContext plannerCtx)
throws SemanticExcept
}
this.ctx.setCboInfo(cboMsg);
- // Determine if we should re-throw the exception OR if we try to
mark plan as reAnalyzeAST to retry
- // planning as non-CBO.
+ // Determine if we should re-throw the exception OR if we try to
mark the query to retry as non-CBO.
Review comment:
That was my first implementation, but that messed up with the current
query outputs (qfiles).
I have tried to throw the ReCompileException (CBOException at that time),
and then decide based on the exception. The problem arisen when I had to
extract and rethrow the cause of the CBOException if the exception was fatal to
provide the same outputs. I have chickened out from that path to keep the
existing logic in place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
