deniskuzZ commented on a change in pull request #2879:
URL: https://github.com/apache/hive/pull/2879#discussion_r770721271
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -506,10 +478,23 @@ protected Boolean findNextCompactionAndExecute(boolean
computeStats) {
task (currently we're using Tez split grouping).
*/
QueryCompactor queryCompactor =
QueryCompactorFactory.getQueryCompactor(t, conf, ci);
+ boolean generic_stats =
conf.getBoolVar(HiveConf.ConfVars.HIVE_COMPACTOR_GATHER_STATS);
Review comment:
Why did you move the config evaluation inside of the compaction loop?
Please use camelCase naming convention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
