marton-bod commented on a change in pull request #2856:
URL: https://github.com/apache/hive/pull/2856#discussion_r779438134
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java
##########
@@ -352,4 +353,12 @@ default URI getURIForAuth(Table table) throws
URISyntaxException {
return new URI(this.getClass().getSimpleName().toLowerCase() + "://" +
HiveCustomStorageHandlerUtils.getTablePropsForCustomStorageHandler(tableProperties));
}
+
+ /**
+ * Validates whether the sink operation is permitted for the specific
storage handler, based
+ * on information contained in the sinkDesc. If the operation is not
allowed, the method should throw an exception.
+ * @param sinkDesc The sink descriptor
+ */
+ default void validateSinkOperation(FileSinkDesc sinkDesc) {
Review comment:
Yep, good idea. Changed it to throw `SemanticException`
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java
##########
@@ -26,14 +26,12 @@
import java.util.Collection;
import java.util.Collections;
import java.util.Comparator;
-import java.util.EnumSet;
Review comment:
Sure, reverted it
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java
##########
@@ -1617,8 +1617,7 @@ public OperatorType getType() {
@Override
public void augmentPlan() {
- PlanUtils.configureOutputJobPropertiesForStorageHandler(
- getConf().getTableInfo());
+
PlanUtils.configureOutputJobPropertiesForStorageHandler(getConf().getTableInfo());
Review comment:
Sure, reverted it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
