veghlaci05 commented on a change in pull request #3000:
URL: https://github.com/apache/hive/pull/3000#discussion_r800473637



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java
##########
@@ -242,6 +242,7 @@ private void scheduleCompactionIfRequired(CompactionInfo 
ci, Table t, Partition
     try {
       ValidWriteIdList validWriteIds = resolveValidWriteIds(t);
       CompactionType type = checkForCompaction(ci, validWriteIds, sd, 
t.getParameters(), runAs);
+      ci.type = type;

Review comment:
       This required to log the proper type in all cases. In case of changing 
the type, and later failing, without this change, the original type would be 
logged.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to