achennagiri commented on a change in pull request #2824:
URL: https://github.com/apache/hive/pull/2824#discussion_r809592375
##########
File path: beeline/pom.xml
##########
@@ -233,6 +233,53 @@
</execution>
</executions>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <descriptorRefs>
+ <descriptorRef>jar-with-dependencies</descriptorRef>
+ </descriptorRefs>
+ <finalName>jar-with-dependencies</finalName>
Review comment:
**_apache-hive-beeline-4.0.0-SNAPSHOT.tar.gz_** is what the final tar gz
output is. To give you a better context, I added this file
https://github.com/achennagiri/hive/blob/a5dab6e8d1b41dd0bbbd0f876be59e24521795d4/packaging/src/main/assembly/beeline.xml
as part of this PR https://github.com/apache/hive/pull/1906/files. As part of
that, I forgot to add the this piece of code which builds the beeline jar with
its dependencies. So, this uber/shaded jar had some problems with the log4j
versioning and hence the use of the transformer code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
