zabetak opened a new pull request #3048: URL: https://github.com/apache/hive/pull/3048
### What changes were proposed in this pull request? Revert HIVE-22753 (commit 6a5c0cd04a2e88a545a96d10a942c86b2be18daa). ### Why are the changes needed? Preventing the creation of the appender (by returning null) leads to the message triggering the creation to be lost forever. Given that the memory leak that was observed in HIVE-22753 is no longer feasible with the fix for HIVE-24590 the changes in HIVE-22753 are redundant and problematic. ### Does this PR introduce _any_ user-facing change? Fixes a bug. ### How was this patch tested? `mvn test -Dtest=TestOperationLoggingAPIWithTez#testFetchResultsOfLogWithExecutionMode` I changed the property (https://github.com/apache/hive/commit/bc6ac75266aa360ce32aa975cf4f7b655cbfd22e) controlling how often appenders are closed to increase the likelihood of hitting the problem and run `TestOperationLoggingAPIWithTez` multiple times. Without the fix the test fails 80% of the time on my machine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
