nrg4878 commented on a change in pull request #3057:
URL: https://github.com/apache/hive/pull/3057#discussion_r817056805
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/events/CreateTableEvent.java
##########
@@ -56,16 +57,28 @@ public HiveMetaStoreAuthzInfo getAuthzContext() {
return ret;
}
- private List<HivePrivilegeObject> getInputHObjs() { return
Collections.emptyList(); }
+ private List<HivePrivilegeObject> getInputHObjs() {
+ List<HivePrivilegeObject> ret = new ArrayList<>();
+ PreCreateTableEvent event = (PreCreateTableEvent) preEventContext;
+ Table table = event.getTable();
+ String uri = getSdLocation(table.getSd());
+
Review comment:
Shouldn't we also add the table itself to this set? Looks like we are
adding just the location check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
