pvary commented on a change in pull request #3079:
URL: https://github.com/apache/hive/pull/3079#discussion_r819622903
##########
File path: ql/src/test/org/apache/hadoop/hive/metastore/TestMetastoreExpr.java
##########
@@ -183,12 +183,12 @@ public void checkExpr(int numParts,
String dbName, String tblName, ExprNodeGenericFuncDesc expr, Table t)
throws Exception {
List<Partition> parts = new ArrayList<Partition>();
client.listPartitionsByExpr(dbName, tblName,
- SerializationUtilities.serializeExpressionToKryo(expr), null,
(short)-1, parts);
+ SerializationUtilities.serializeObjectWithTypeInformation(expr), null,
(short)-1, parts);
assertEquals("Partition check failed: " + expr.getExprString(), numParts,
parts.size());
// check with partition spec as well
PartitionsByExprRequest req = new PartitionsByExprRequest(dbName, tblName,
-
ByteBuffer.wrap(SerializationUtilities.serializeExpressionToKryo(expr)));
+
ByteBuffer.wrap(SerializationUtilities.serializeObjectWithTypeInformation(expr)));
Review comment:
nit: funny that the indentation is different than the above one.
If we touch the line fix the indentation please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
