zabetak commented on a change in pull request #3081:
URL: https://github.com/apache/hive/pull/3081#discussion_r822746338
##########
File path:
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/tools/schematool/TestSchemaToolForMetastore.java
##########
@@ -370,6 +370,44 @@ public void testSchemaUpgrade() throws Exception {
schemaTool.verifySchemaVersion();
}
+ /**
+ * Test schema upgrade checking that the alpha version is called
+ */
+ @Test
+ public void testSchemaUpgradeFromAlphaVersion() throws Exception {
Review comment:
It's true that `DbInstallBase` tests are a bit trickier to run but they
should run everywhere. The following works for me locally:
`mvn -pl standalone-metastore/metastore-server/ verify -DskipITests=false
-Dit.test=ITestDerby -Dtest=nosuch`
Moreover, I don't find a strong reason to have these `DbInstallBase`
declared as integration tests. They just complicate our lives.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
