wecharyu commented on a change in pull request #3085:
URL: https://github.com/apache/hive/pull/3085#discussion_r823475572
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
##########
@@ -2333,11 +2333,6 @@ private void create_table_core(final RawStore ms, final
CreateTableRequest req)
isReplicated = isDbReplicationTarget(db);
firePreEvent(new PreCreateTableEvent(tbl, db, this));
- // get_table checks whether database exists, it should be moved here
- if (is_table_exists(ms, tbl.getCatName(), tbl.getDbName(),
tbl.getTableName())) {
- throw new AlreadyExistsException("Table " +
getCatalogQualifiedTableName(tbl)
- + " already exists");
- }
Review comment:
Double check is not necessary, transactions of different `pm`s do not
affect each other, and the eventual consistency is guaranteed by the backend
RDBMS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
