deniskuzZ commented on a change in pull request #3126:
URL: https://github.com/apache/hive/pull/3126#discussion_r834209227
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -627,18 +617,52 @@ public CompactorMR getMrCompactor() {
return new CompactorMR();
}
- private void markFailed(CompactionInfo ci, String errorMessage) {
- if (ci != null && StringUtils.isNotBlank(errorMessage)) {
- ci.errorMessage = errorMessage;
+ private void markWithState(CompactionInfo ci, Object error, CompactionState
state) {
+ if (ci == null) {
+ LOG.warn("Could not set compaction info state because it is null!");
+ throw new RuntimeException("Could not set compaction info state because
it is null!");
}
+ String defaultMessage = "Error during compaction. Compaction info: " + ci;
Review comment:
this could be extracted into the getErrorDetails method and reused under
the switch statement
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -627,18 +617,52 @@ public CompactorMR getMrCompactor() {
return new CompactorMR();
}
- private void markFailed(CompactionInfo ci, String errorMessage) {
- if (ci != null && StringUtils.isNotBlank(errorMessage)) {
- ci.errorMessage = errorMessage;
+ private void markWithState(CompactionInfo ci, Object error, CompactionState
state) {
+ if (ci == null) {
+ LOG.warn("Could not set compaction info state because it is null!");
+ throw new RuntimeException("Could not set compaction info state because
it is null!");
}
+ String defaultMessage = "Error during compaction. Compaction info: " + ci;
Review comment:
this could be extracted into the getErrorDetails() method and reused
under the switch statement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
