amansinha100 commented on a change in pull request #3156:
URL: https://github.com/apache/hive/pull/3156#discussion_r840116428
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/hooks/QueryLifeTimeHookContextImpl.java
##########
@@ -78,11 +88,12 @@ public Builder withHookContext(HookContext hc) {
return this;
}
- public QueryLifeTimeHookContextImpl build() {
+ public QueryLifeTimeHookContextImpl build(String queryId) {
QueryLifeTimeHookContextImpl queryLifeTimeHookContext = new
QueryLifeTimeHookContextImpl();
queryLifeTimeHookContext.setHiveConf(this.conf);
queryLifeTimeHookContext.setCommand(this.command);
queryLifeTimeHookContext.setHookContext(this.hc);
+ queryLifeTimeHookContext.queryId = Objects.requireNonNull(queryId);
Review comment:
Yes, sanity check was the only ask. Changes LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
