zabetak commented on code in PR #3168:
URL: https://github.com/apache/hive/pull/3168#discussion_r844887792
##########
standalone-metastore/metastore-server/pom.xml:
##########
@@ -474,23 +474,6 @@
</target>
</configuration>
</execution>
- <execution>
- <id>generate-version-annotation</id>
- <phase>generate-sources</phase>
- <configuration>
- <target>
- <exec executable="bash" failonerror="true">
- <arg value="${basedir}/src/main/resources/saveVersion.sh"/>
- <arg value="${project.version}"/>
- <arg value="${hive.version.shortname}"/>
- <arg value="${basedir}/src"/>
- </exec>
- </target>
- </configuration>
- <goals>
- <goal>run</goal>
- </goals>
- </execution>
Review Comment:
Do we know why was this introduced in the first place and if it is safe to
remove?
If I understood well this is the main point of the fix, can you confirm?
##########
standalone-metastore/pom.xml:
##########
@@ -531,6 +531,30 @@
</os>
</activation>
</profile>
+ <profile>
+ <id>javadoc</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-javadoc-plugin</artifactId>
+ <configuration>
+ <doclint>none</doclint>
+ <additionalparam>-Xdoclint:none</additionalparam>
Review Comment:
Do we need both?
##########
pom.xml:
##########
@@ -1810,6 +1810,7 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<configuration>
+ <doclint>none</doclint>
<additionalparam>-Xdoclint:none</additionalparam>
Review Comment:
Is this change mandatory for building javadocs?
Aren't these two lines somewhat equivalent? Why do we need both?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
