ayushtkn commented on code in PR #3187:
URL: https://github.com/apache/hive/pull/3187#discussion_r845927749


##########
ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/ValueBoundaryScanner.java:
##########
@@ -768,6 +774,9 @@ public static SingleValueBoundaryScanner 
getBoundaryScanner(BoundaryDef start, B
     case "string":
       return new StringPrimitiveValueBoundaryScanner(start, end, exprDef, 
nullsLast);
     default:
+      if (typeString.startsWith("char") || typeString.startsWith("varchar")) {

Review Comment:
   can't do that. the entries aren't fixed char or varchar, they are like 
char(10) or char(5) or varchar(5) or varchar(6) like that. So putting char or 
varchar in switch-case won't work



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to