pvary commented on code in PR #3168:
URL: https://github.com/apache/hive/pull/3168#discussion_r845966555


##########
standalone-metastore/metastore-server/pom.xml:
##########
@@ -474,23 +474,6 @@
               </target>
             </configuration>
           </execution>
-          <execution>
-            <id>generate-version-annotation</id>
-            <phase>generate-sources</phase>
-            <configuration>
-              <target>
-                <exec executable="bash" failonerror="true">
-                  <arg value="${basedir}/src/main/resources/saveVersion.sh"/>
-                  <arg value="${project.version}"/>
-                  <arg value="${hive.version.shortname}"/>
-                  <arg value="${basedir}/src"/>
-                </exec>
-              </target>
-            </configuration>
-            <goals>
-              <goal>run</goal>
-            </goals>
-          </execution>

Review Comment:
   Moved the `MetastoreVersionInfo` as suggested.
   We do not use it without the `metastore-common`, so it was not causing any 
issues, but it is more logical this way



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to