asolimando commented on PR #3196: URL: https://github.com/apache/hive/pull/3196#issuecomment-1094860222
> I really don't like to grow the number of core cli test drivers; why do we need separate for oracle/etc? > > can't we use a qoption instead of a whole set of new drivers? > > I wonder if we really need to have mile long q.out results for these kind of things. I think these kind of things should be run as part of some automated smoke tests for the release - with a real installation undernteath The existing test infra could be improved in many ways, regarding the metastore bit, there is already a ticket: https://issues.apache.org/jira/browse/HIVE-26005. We have discussed offline with @zabetak and we thought it would be better to move forward with what we have, and to tackle the improvement in the other ticket, since at the moment we already have broken support for mysql for sysdb: https://issues.apache.org/jira/browse/HIVE-26125. If you think HIVE-26005 is a must-do, please update the link between the tickets accordingly and I will pause this until me or somebody else finds the time to tackle it, otherwise if you agree that is better to have more coverage now and improve tests later, I am open to suggestions on how to improve the current proposal. I have explored the qoption way you suggest (adding a metastore option to sysdb qoption), I can start the sought docker containers, but changing the configuration properties to use another metastore failed, the new cli driver was the only way I could make these tests working. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
