hsnusonic commented on code in PR #3198:
URL: https://github.com/apache/hive/pull/3198#discussion_r848688003
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:
##########
@@ -5399,7 +5399,12 @@ public void cleanUpOneDirectoryForReplace(Path path,
FileSystem fs,
if (isNeedRecycle && conf.getBoolVar(HiveConf.ConfVars.REPLCMENABLED)) {
recycleDirToCmPath(path, purge);
Review Comment:
Thank you for catching this. It looks like `recycleDirToCmPath` might also
failed if a path does not exist. The intention was to avoid one additional file
system call, however, it seems unavoidable. I added the path check before
calling `cleanUpOneDirectoryForReplace`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
