pvary commented on code in PR #3218:
URL: https://github.com/apache/hive/pull/3218#discussion_r857332648
##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/AuthorizationMetaStoreFilterHook.java:
##########
@@ -46,11 +46,18 @@ public AuthorizationMetaStoreFilterHook(Configuration conf)
{
}
@Override
- public List<String> filterTableNames(String catName, String dbName,
List<String> tableList)
+ public List<String> filterTableNames(String dbName, List<String> tableList)
throws MetaException {
List<HivePrivilegeObject> listObjs = getHivePrivObjects(dbName, tableList);
return getTableNames(getFilteredObjects(listObjs));
}
+
+ @Override
+ public List<String> filterTableNames(String catName, String dbName,
List<String> tableList)
+ throws MetaException {
+ return filterTableNames(dbName, tableList);
Review Comment:
This seems problematic to me.
If we ignore the catalog name, that could become a serious hidden issue.
Do we have a better solution to this?
Maybe throw an exception if the catalog name is not the default? Or do the
filtering correctly with the catalog info as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
