lcspinter commented on code in PR #3270:
URL: https://github.com/apache/hive/pull/3270#discussion_r869991050
##########
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerNoScan.java:
##########
@@ -1456,6 +1456,63 @@ public void testCreateTableWithMetadataLocation() throws
IOException {
HiveIcebergStorageHandlerTestUtils.CUSTOMER_RECORDS.stream()).collect(Collectors.toList()),
records, 0);
}
+ @Test
+ public void testAlterTableWithMetadataLocation() throws IOException {
+ Assume.assumeTrue("Alter table with metadata location is only supported
for Hive Catalog tables",
Review Comment:
I'm not sure this is inconsistent. The HMS table property
`metadata_location` has a special meaning if the table belongs to the hive
catalog. It is also treated differently in our `HiveTableOperations` class,
refreshing the metadata based on the value of this property.
In the case of tables from other catalog types, this is just a regular table
property and it doesn't have any highlighted meaning. So I run an alter query I
would expect that the table property is changed but nothing else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
