zabetak commented on code in PR #3295:
URL: https://github.com/apache/hive/pull/3295#discussion_r882128671
##########
ql/src/test/org/apache/hadoop/hive/ql/io/parquet/serde/TestParquetTimestampsHive2Compatibility.java:
##########
@@ -79,6 +79,18 @@ void testWriteHive2ReadHive4UsingLegacyConversion(String
timestampString) {
assertEquals(timestampString, ts.toString());
}
+ /**
+ * Tests that timestamps written using Hive2 APIs are read correctly by
Hive4 APIs when legacy conversion is on.
+ */
+ @ParameterizedTest(name = "{0}")
+ @MethodSource("generateTimestamps")
+ void testWriteHive2ReadHive4UsingLegacyConversionWithZone(String
timestampString) {
+ String zoneId = "US/Pacific";
+ NanoTime nt = writeHive2(timestampString);
Review Comment:
Since there is no parameter in `writeHive2` for specifying the timezone I
think you will need to call `TimeZone.setDefault()` explicitly otherwise it
will not work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
