wecharyu commented on code in PR #3360:
URL: https://github.com/apache/hive/pull/3360#discussion_r899246871
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/function/create/CreateFunctionOperation.java:
##########
@@ -116,11 +119,27 @@ private int createPermanentFunction() throws
HiveException, IOException {
return 1;
}
- boolean addToMetastoreSuccess = addToMetastore(dbName, functionName,
registeredName);
- if (!addToMetastoreSuccess) {
+ // TODO: should this use getUserFromAuthenticator instead of
SessionState.get().getUserName()?
+ Function function = new Function(functionName, dbName,
desc.getClassName(), SessionState.get().getUserName(),
Review Comment:
Can we add `OWNER_PRIV` for altering function? Then only the owner of this
function can do alter operation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
