hsnusonic commented on code in PR #3381:
URL: https://github.com/apache/hive/pull/3381#discussion_r901977331
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:
##########
@@ -461,6 +459,14 @@ public Thread newThread(@NotNull Runnable r) {
// TODO: AcceptQueueSize needs to be higher for HMS
connector.setAcceptQueueSize(maxWorkerThreads);
// TODO: Connection keepalive configuration?
+ connector.addBean(new HttpChannel.Listener() {
+ @Override
+ public void onComplete(Request request) {
+ LOG.debug("Request " + request + " is completed. HttpChannel was: " +
request.getHttpChannel()
+ + ", HttpTransport: " +
request.getHttpChannel().getHttpTransport());
+ HMSHandler.cleanupHandlerContext();
Review Comment:
Is it possible to add a unit test to make sure we indeed clean up all of
objects that need to be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
