pvary commented on code in PR #3362:
URL: https://github.com/apache/hive/pull/3362#discussion_r907336065
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java:
##########
@@ -305,13 +414,14 @@ private Set<FileStatus> listForCommits(JobConf jobConf,
String jobLocation) thro
* Collects the additions to a single table and adds/commits the new files
to the Iceberg table.
* @param io The io to read the forCommit files
* @param executor The executor used to read the forCommit files
- * @param jobContext The job context
- * @param name The name of the table used for loading from the catalog
+ * @param outputTable The table used for loading from the catalog
* @param location The location of the table used for loading from the
catalog
* @param catalogName The name of the catalog that contains the table
*/
- private void commitTable(FileIO io, ExecutorService executor, JobContext
jobContext, String name, String location,
+ private void commitTable(FileIO io, ExecutorService executor, OutputTable
outputTable, String location,
Review Comment:
Would it make sense to put the `location` and the `catalogName` to the
`OutputTable` object?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
