deniskuzZ commented on PR #3303: URL: https://github.com/apache/hive/pull/3303#issuecomment-1168345079
> > I think we should do something like this: > > ``` > > ExecutorService executorService = CompactorUtil.createExecutorWithThreadFactory(numberOfWorkers, "CompactionHeartbeat-executor-thread-%d"); > > > > Future<?> submittedTask = heartbeatExecutor.scheduleAtFixedRate(() -> executorService.execute(heartbeater)); > > tasks.put(txnId, new TaskWrapper(heartbeater, submittedTask)); > > ``` > > What is the benefit of this construct? none, I was playing with it trying to extract CompletableFuture, so we can just call 'join' or 'get' instead on manual hacks in runnable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
