kasakrisz opened a new pull request, #3430:
URL: https://github.com/apache/hive/pull/3430
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA:
https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
1. Extract common parts which collects and appends the sort and delete
columns in case of split update and merge.
2. Merge IcebergWriter data and delete file collections.
3. Append the number of writers in the job to the operationId to generate a
unique file name for each writer.
### Why are the changes needed?
1. Implement merge into iceberg table by reusing split update code parts.
2. A merge with an insert and an update branch has at least two insert
IcebergWriters. If the target table is not partitioned no sorting and exchange
is required and both FileSink operators wrapping the IcebergWriters are located
in the same Reducer and Job.
### Does this PR introduce _any_ user-facing change?
Yes. Merge statements should not throw any exceptions when the target is an
iceberg table.
### How was this patch tested?
```
mvn test -Dtest.output.overwrite -DskipSparkTests
-Dtest=TestIcebergLlapLocalCliDriver
-Dqfile=merge_iceberg_orc.q,merge_iceberg_partitioned_orc.q -pl
itests/qtest-iceberg -Piceberg -Pitests
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
