wecharyu commented on code in PR #3431:
URL: https://github.com/apache/hive/pull/3431#discussion_r923500483
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -7791,7 +7791,7 @@ public List<String> get_role_names() throws TException {
ret = getMS().listRoleNames();
return ret;
} catch (Exception e) {
- throw
handleException(e).throwIfInstance(MetaException.class).defaultRuntimeException();
Review Comment:
Thanks for your concern @dengzhhu653.
Converting to `TException` should be OK because it is actually converted to
a `MetaException`:
```java
//
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ExceptionHandler.java
public TException defaultTException() {
if (e instanceof TException) {
return (TException) e;
}
return newMetaException(e);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
