dengzhhu653 commented on code in PR #3477:
URL: https://github.com/apache/hive/pull/3477#discussion_r930579455
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2040,7 +2044,10 @@ struct CreateDatabaseRequest {
9: optional i32 createTime,
10: optional string managedLocationUri,
11: optional string type,
- 12: optional string dataConnectorName
+ 12: optional string dataConnectorName,
+ // use boolean skipFSWrites to decide whether create directory in file
system or not
+ 13: optional bool skipFSWrites=false,
+ 14: optional Database database
Review Comment:
Do we need `optional Database database` here? or can we just put the
`skipFSWrites` into the struct `Database`, so that the old client can be able
to skip create directory with less changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
