DanielZhu58 commented on code in PR #3477:
URL: https://github.com/apache/hive/pull/3477#discussion_r942219606
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -901,7 +901,9 @@ struct AddPartitionsRequest {
4: required bool ifNotExists,
5: optional bool needResult=true,
6: optional string catName,
- 7: optional string validWriteIdList
+ 7: optional string validWriteIdList,
+ // use boolean skipFSWrites to decide whether create directory in file
system or not
+ 8: optional bool skipFSWrites=false
Review Comment:
Yes, we do. Because that's one of the requirement of this patch.
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2040,7 +2044,10 @@ struct CreateDatabaseRequest {
9: optional i32 createTime,
10: optional string managedLocationUri,
11: optional string type,
- 12: optional string dataConnectorName
+ 12: optional string dataConnectorName,
+ // use boolean skipFSWrites to decide whether create directory in file
system or not
+ 13: optional bool skipFSWrites=false,
+ 14: optional Database database
Review Comment:
Yes, we do. Because in the create database function with signature
CreateDatabaseRequest, we will use getDatabase() function. This will need the
`optional Database database`.
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -1229,74 +1229,78 @@ private void create_database_core(RawStore ms, final
Database db)
Map<String, String> transactionalListenersResponses =
Collections.emptyMap();
try {
firePreEvent(new PreCreateDatabaseEvent(db, this));
- //reinstate location uri for metastore db.
- if (skipAuthorization == true){
Review Comment:
We can leave it the same way this time. Because this change is not highly
related with the HMS directory skipping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
