deniskuzZ commented on code in PR #3524:
URL: https://github.com/apache/hive/pull/3524#discussion_r949855565
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:
##########
@@ -4053,14 +4053,25 @@ public void replTableWriteIdState(String
validWriteIdList, String dbName, String
@Override
public long allocateTableWriteId(long txnId, String dbName, String
tableName) throws TException {
- return allocateTableWriteIdsBatch(Collections.singletonList(txnId),
dbName, tableName).get(0).getWriteId();
+ return allocateTableWriteId(txnId, dbName, tableName, false);
}
@Override
- public List<TxnToWriteId> allocateTableWriteIdsBatch(List<Long> txnIds,
String dbName, String tableName)
- throws TException {
+ public long allocateTableWriteId(long txnId, String dbName, String
tableName, boolean shouldRealloc) throws TException {
+ return allocateTableWriteIdsBatch(Collections.singletonList(txnId),
dbName, tableName, shouldRealloc).get(0).getWriteId();
+ }
+
+
+ @Override
+ public List<TxnToWriteId> allocateTableWriteIdsBatch(List<Long> txnIds,
String dbName, String tableName) throws TException {
+ return allocateTableWriteIdsBatch(txnIds, dbName, tableName, false);
+ }
+
+ public List<TxnToWriteId> allocateTableWriteIdsBatch(List<Long> txnIds,
String dbName, String tableName,
Review Comment:
can we mark it as private? it's not exposed in the API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
