SourabhBadhya commented on code in PR #3528:
URL: https://github.com/apache/hive/pull/3528#discussion_r954583123
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionInfo.java:
##########
@@ -109,6 +109,13 @@ public void setProperty(String key, String value) {
properties = propertiesMap.toString();
}
+ public StringableMap getPropertiesMap() {
Review Comment:
Done.
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactor.java:
##########
@@ -272,5 +277,23 @@ static void removeFilesForMmTable(HiveConf conf,
AcidDirectory dir) throws IOExc
fs.delete(dead, true);
}
}
+
+ static void overrideConfProps(HiveConf conf, CompactionInfo ci,
Map<String, String> properties) {
+ for (String key : properties.keySet()) {
+ if (key.startsWith(COMPACTOR_PREFIX)) {
+ String property = key.substring(10); // 10 is the length of
"compactor." We only keep the rest.
+ conf.set(property, properties.get(key));
+ }
+ }
+
+ // Give preference to properties coming from compaction
+ // over table properties
+ for (String key : ci.getPropertiesMap().keySet()) {
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
