difin commented on code in PR #3559:
URL: https://github.com/apache/hive/pull/3559#discussion_r962084263
##########
ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java:
##########
@@ -885,7 +886,20 @@ static Path[] getDeleteDeltaDirsFromSplit(OrcSplit
orcSplit,
} else {
throw new IllegalStateException("Split w/o base w/Acid 2.0??: " + path);
}
- return AcidUtils.deserializeDeleteDeltas(root, orcSplit.getDeltas(),
pathToDeltaMetaData);
+
+ // filtering out delete_delta folders containing transactions that
happened only before
+ // transactions of the split
+ List<AcidInputFormat.DeltaMetaData> deltas = orcSplit.getDeltas();
Review Comment:
Yes, I agree it is better and I made the filtering of irrelevant deltas to
happen on the split initialization as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
